Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move MIDI classes to a separate package #366

Merged
merged 1 commit into from
Nov 26, 2023
Merged

Move MIDI classes to a separate package #366

merged 1 commit into from
Nov 26, 2023

Conversation

frostburn
Copy link
Member

ref #336

forrcaho
forrcaho reviewed Jan 29, 2023
View reviewed changes
Copy link
Contributor

@forrcaho forrcaho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you've moved the xen-midi package to npmjs.org along with the others -- the package.json here wants to get it from github.

@frostburn
Copy link
Member Author

Self-reviewing: Works with my old KeyControl 49 and outputs pitch-bent MIDI to QSynth. ✔️

@frostburn
Copy link
Member Author

Oh, one thing: xen-midi still depends on the old xen-dev-utils.

@frostburn frostburn merged commit 3707b7f into main Nov 26, 2023
1 check passed
@frostburn frostburn deleted the xen-midi branch November 26, 2023 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@forrcaho forrcaho forrcaho left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@frostburn @forrcaho