fixed naming of css spacing additions for grouped elements (checkbox,…

… radio, dropdown)
xenharmonic-devs · Apr 13, 2024 · 60ea5a8 · 60ea5a8
1 parent 52ce45a
commit 60ea5a8
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 11 deletions.
diff --git a/src/App.vue b/src/App.vue
@@ -84,12 +84,7 @@ function midiNoteOn(index: number, rawAttack?: number, channel?: number) {
     rawAttack = 80
   }
 
-  let frequency = scale.frequencies[index]
-
-  // if index out of range calculate frequency directly
-  if (index < 0 || index > 127) {
-    frequency = scale.getFrequency(index)
-  }
+  let frequency = scale.getFrequency[index]
 
   if (!midi.velocityOn) {
     rawAttack = 80

diff --git a/src/assets/main.css b/src/assets/main.css
@@ -139,19 +139,21 @@ ul.btn-group {
 }
 .control.checkbox-container {
   flex-flow: unset;
-  gap: 0.15rem 1rem;
 }
 .control.checkbox-container label {
   font-weight: normal;
 }
+.control.checkbox-group {
+  flex-flow: unset;
+  gap: 0.15rem 1rem;
+}
 .control.radio-group {
   gap: 0.15rem 1rem;
 }
 .control.radio-group span label {
   font-weight: unset;
 }
-.control.select-group {
-  flex-flow: unset;
+.control.dropdown-group {
   gap: 0.15rem 1rem;
 }
 

diff --git a/src/views/MidiView.vue b/src/views/MidiView.vue
@@ -178,7 +178,7 @@ onUnmounted(() => {
               />
             </span>
           </div>
-          <div class="control checkbox-container">
+          <div class="control checkbox-group">
             <span>
               <input type="checkbox" id="midi-velocity" v-model="midi.velocityOn" />
               <label for="midi-velocity"> Use velocity </label>
@@ -189,7 +189,7 @@ onUnmounted(() => {
             </span>
           </div>
           <label>Settings for multichannel-to-equave mode</label>
-          <div class="control select-group">                    
+          <div class="control dropdown-group">                    
             <span> Center channel <input id="multichannel-center" class="control" type="number" min="1" max="16" value="3" v-model="midi.multichannelCenter" />
             </span>
             <span> Total equaves <input id="multichannel-num-equaves" class="control" type="number" min="1" max="16" value="8" v-model="midi.multichannelNumEquaves" />