Fix NaN values crashing the audio system

Render NaN frequencies without a metric prefix.
xenharmonic-devs · Apr 2, 2024 · 1067b36 · 1067b36
1 parent 924c84a
commit 1067b36
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/src/App.vue b/src/App.vue
@@ -47,6 +47,9 @@ const midiOut = computed(() => new MidiOut(midi.output as Output, midi.outputCha
 
 function sendNoteOn(frequency: number, rawAttack: number) {
   frequency = clamp(-24000, 24000, frequency)
+  if (isNaN(frequency)) {
+    frequency = 0
+  }
   const midiOff = midiOut.value.sendNoteOn(frequency, rawAttack)
 
   if (audio.synth === null || audio.virtualSynth === null) {

diff --git a/src/utils.ts b/src/utils.ts
@@ -176,7 +176,7 @@ export function formatHertz(frequency: number, fractionDigits = 3) {
   }
 
   // Too large. Use scientific notation.
-  if (magnitude > 1e34) {
+  if (magnitude > 1e34 || isNaN(magnitude)) {
     return formatExponential(frequency) + 'Hz'
   }