Skip to content

Commit

Permalink
Fix remaining scale.scale.baseMidiNote dependencies
Browse files Browse the repository at this point in the history
Update sonic-weave dependency.
  • Loading branch information
frostburn committed Apr 19, 2024
1 parent cd800e3 commit 0357630
Show file tree
Hide file tree
Showing 4 changed files with 21 additions and 9 deletions.
22 changes: 17 additions & 5 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "scale-workshop",
"version": "3.0.0-beta.14",
"version": "3.0.0-beta.15",
"scripts": {
"dev": "vite",
"build": "run-p type-check \"build-only {@}\" --",
Expand All @@ -21,7 +21,7 @@
"moment-of-symmetry": "^0.4.2",
"pinia": "^2.1.7",
"qs": "^6.12.0",
"sonic-weave": "github:xenharmonic-devs/sonic-weave#v0.0.20",
"sonic-weave": "github:xenharmonic-devs/sonic-weave#v0.0.21",
"sw-synth": "^0.1.0",
"temperaments": "^0.5.3",
"vue": "^3.3.4",
Expand Down
2 changes: 1 addition & 1 deletion src/components/modals/modification/ApproximateByRatios.vue
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ type Approximation = {
}
const approximationsWithErrorsAndLimits = computed<Approximation[]>(() => {
const selected = Math.abs(scale.scale.getRatio(scale.baseMidiNote + approx.degree))
const selected = Math.abs(scale.scale.getRatio(scale.scale.baseMidiNote + approx.degree))
const selectedCents = valueToCents(selected)
if (approx.method === 'convergents') {
const approximations = getConvergents(
Expand Down
2 changes: 1 addition & 1 deletion src/components/modals/modification/EqualizeScale.vue
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ const scale = useScaleStore()
const equalizedScaleData = computed(() => {
const pitches = [...Array(scale.scale.size).keys()].map((i) =>
valueToCents(Math.abs(scale.scale.getRatio(i + scale.baseMidiNote)))
valueToCents(Math.abs(scale.scale.getRatio(i + scale.scale.baseMidiNote)))
)
const gridCents = valueToCents(scale.scale.equaveRatio) / modal.largeDivisions
if (modal.errorModel === 'rooted') {
Expand Down

0 comments on commit 0357630

Please sign in to comment.