Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add GetUserIDByEmail #166

Merged
merged 1 commit into from
Aug 14, 2023

Conversation

kanzihuang
Copy link
Contributor

No description provided.

Copy link
Owner

@xen0n xen0n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

请 rebase 到最新 develop 分支状态,其他应该没问题,感谢贡献!

@@ -49,6 +49,21 @@ func (c *WorkwxApp) GetUserIDByMobile(mobile string) (string, error) {
return resp.UserID, nil
}

// GetUserIDByEmail 通过邮箱获取 userid
func (c *WorkwxApp) GetUserIDByEmail(email string, emailType EmailType) (string, error) {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

让邮箱类型出现在邮箱取值之前,会不会更符合直觉?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

从「这个参数可以不传」的角度看,目前的传参顺序或许也行

@kanzihuang
Copy link
Contributor Author

已 rebase 到最新 develop 分支状态并重新创建PR,PR编号为 #168

Copy link
Owner

@xen0n xen0n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

Thanks!

@bors
Copy link
Contributor

bors bot commented Aug 14, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit 3eae0fe into xen0n:develop Aug 14, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants