Thorchain client refactor #997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
14
to
28
| export function makeClientPath(fullDerivationPath: string): HdPath { | ||
| const out = new Array<Slip10RawIndex>() | ||
| let path = `/${fullDerivationPath}` | ||
| while (path) { | ||
| const match = path.match(/^\/([0-9]+)('?)/) | ||
| if (!match) throw new Error('Syntax error while reading path component') | ||
| const [fullMatch, numberString, apostrophe] = match | ||
| const value = Uint53.fromString(numberString).toNumber() | ||
| if (value >= 2 ** 31) throw new Error('Component value too high. Must not exceed 2**31-1.') | ||
| if (apostrophe) out.push(Slip10RawIndex.hardened(value)) | ||
| else out.push(Slip10RawIndex.normal(value)) | ||
| path = path.slice(fullMatch.length) | ||
| } | ||
| return out | ||
| } |
There was a problem hiding this comment.
Why don't use function form official package ? https://cosmos.github.io/cosmjs/latest/crypto/modules.html#stringToPath
There was a problem hiding this comment.
It can be used, but the default value of the rootDerivationPath has to be changed to 'm' format
|
With this new commit, client uses the cosmjs function and it is compatible with old packages versions |
hippocampus-web3
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thorchain client migration to use the cosmos-sdk package as its foundation:
Breaking changes:
getPrivateKeyis now async and response is Uint8Array typegetPubKeyis now async and response is Uint8Array typegetDepositTransactionis deprecated in favour ofgetTransactionDatafetchTransactionremovedsetClientUrlremovedgetClientUrlremovedsetExplorerUrlsremovedgetCosmosClientremovedsetNetworkremovedsetChainIdremovedgetChainIdremoved