add arbitrum to chainflip #1291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juanfri-web3
force-pushed
the
add-arbitrum-to-chainflip
branch
2 times, most recently
from
5f3a28c to
ed0382c
Compare
juanfri-web3
force-pushed
the
add-arbitrum-to-chainflip
branch
from
ed0382c to
8abea2c
Compare
0xp3gasus
suggested changes
Oct 3, 2024
| @@ -38,10 +38,10 @@ export class ChainflipProtocol implements IProtocol { | |||
| }, 24 * 60 * 60 * 1000) | |||
| } | |||
| approveRouterToSpend(_params: { asset: TokenAsset; amount?: CryptoAmount }): Promise<TxSubmitted> { | |||
| throw new Error('Method not implemented.') | |||
| throw new Error('Not implemented') | |||
| } | |||
| shouldBeApproved(_params: { asset: TokenAsset; amount: CryptoAmount; address: string }): Promise<boolean> { | |||
There was a problem hiding this comment.
Use async nomenclature and add method visibility
0xp3gasus
approved these changes
Oct 3, 2024
0xp3gasus
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Arbitrum to Chainflip