-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1021 Asset type refactor #1202
Merged
Merged
1021 Asset type refactor #1202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
* Wallet reafactored with new Asset type * MAYA protocol with new Asset type and CryptoAmount class * Thorchain protocol with new Asset type and CryptoAmount class * Aggregator with new Asset type and CryptoAmount class * Missing changes * Clean Cryptoamount * 1205 aggregator affiliates (#1206) * Affiliate bug fix in doSwap * Changeset version file * Version Packages (#1210) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * 1207 Estimate MAYAName (#1211) * getMAYANameDetails response standardise with Thorchain * Estimate MAYAName * Tests * Changeset version file * 1196 Mayachain AMM docs (#1197) * Get MAYANames by address * Changeset version file * MAYAChainAMM docs * Readme links * Dependencies removed * Changeset version files removed * 1212 Register and Update Thorname and MAYAName (#1214) * getMAYANameDetails response standardise with Thorchain * Estimate MAYAName * Tests * Changeset version file * MAYAName feature * Tests * Register and Update THORName * Error bug fix * Tests * Changeset version files * Version Packages (#1215) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * 1208 Update THORChain client apis (#1216) * Thornode v1.133.0 * Midgard v2.32.2 * Changeset version files * Action TxType parameter * Tests * Changeset version file * 1208 Update MAYAChain client apis (#1217) * MAYANode v1.110.0 * Streaming swap parameters for quote swap * MAYAChainAMM tests * Midgard v2.10.0 * Changeset version files * Version Packages (#1220) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * 1223 MAYAChain streaming swaps (#1222) * Streaming and missing parameters for QuoteSwap type * Tests * Changeset version files * e2e tests * Changeset version files * 1201 Examples and tests with new Asset type and CryptoAmount refactor (#1204) * Examples and tests with new Asset type and CryptoAmount refactor * Example bug fix --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Thorian1te
approved these changes
Jul 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Huge Pr, it looks okay. good to see all the new tests. lets get it out there
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.