Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add calculation of essential diagnostic variables to postprocess #59

Merged
merged 4 commits into from
Mar 8, 2022

Conversation

jthielen
Copy link
Collaborator

@jthielen jthielen commented Mar 7, 2022

Change Summary

As discussed in #57, this adds the calculation of potential temperature, air pressure, geopotential, and geopotential height to postprocess. Both this step and the substep of dropping the underlying raw variables used are conditional using keyword arguments.

Related issue number

Closes #57

Checklist

  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable

@jthielen jthielen added the enhancement New feature or request label Mar 7, 2022
@jthielen jthielen added this to the v0.0.1 milestone Mar 7, 2022
@jthielen
Copy link
Collaborator Author

jthielen commented Mar 7, 2022

Since I have docstring comments relating to Dask, but don't actually check any of that here, I've added #60 as a reminder for later.

xwrf/accessors.py Outdated Show resolved Hide resolved
xwrf/postprocess.py Outdated Show resolved Hide resolved
Copy link
Member

@andersy005 andersy005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! Thank you @jthielen

Copy link
Collaborator

@lpilz lpilz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Thanks, @jthielen

@andersy005 andersy005 merged commit 0c500fc into xarray-contrib:main Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE]: Essential diagnostic variables
3 participants