CA-404013: replace Thread.delay with Delay module #6213
Conversation
There was a problem hiding this comment.
Other than https://github.com/xapi-project/xen-api/pull/6213/files#r1905402492 this looks good
| @@ -57,10 +59,20 @@ type state = | |||
| | Cancelled | |||
| | Stopped of [`New | `Cancelled | `Failed of exn] | |||
There was a problem hiding this comment.
Unrelated - but I would have preferred this to be a regular sum type. This module needs to be in scope so I don't see the benefit to use a polymorphic sum type.
|
I don't see a problem with this patch, but there is a test failure that we need to understand before merging. |
Reporter.cancel would be blocked for a long time by backoff delay when another thread is waiting for next reading, replace Thread.delay with Delay module so that Reporter.cancel will not be blocked. Signed-off-by: Gang Ji <[email protected]>
gangj
force-pushed
the
private/gangj/CA-404013
branch
from
518ecec to
5efa5d0
Compare
The failed test TCRrdLogSpam has comments: "rrdd-iostat shouldn't spam the logs", in the private build which failed the test, I added some logs in rrdd code. |
Reporter.cancel would be blocked for a long time by backoff delay when another thread is waiting for next reading, replace Thread.delay with Delay module so that Reporter.cancel will not be blocked.