Minimize xenstore accesses during domid-to-uuid lookups #6129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bake in assumptions that have been constant ever since xenstore was created: getdomainpath always returns "/local/domain/<domid>", /local/domain/domid/vm returns "/vm/<uuid>", so there's no need to look up that path to get the uuid again This reduces the number of xenstore accesses from 3 to 1 with no functional change. As suggested in: xapi-project#6068 (review) Signed-off-by: Andrii Sultanov <[email protected]>
last-genius
force-pushed
the
private/asultanov/rrdd-xenctrl-fix
branch
from
a126f22 to
21d6773
Compare
robhoes
reviewed
Nov 20, 2024
| |> String.split_on_char '/' | ||
| in | ||
| match vm_uuid_path with | ||
| | [_; _; uuid] -> |
There was a problem hiding this comment.
Just checking....
utop # String.split_on_char '/' "/vm/67c0a36c-be5f-b3b3-8652-ff17a974ae2a";;
- : string list = [""; "vm"; "67c0a36c-be5f-b3b3-8652-ff17a974ae2a"]
robhoes
approved these changes
Nov 20, 2024
psafont
approved these changes
Nov 20, 2024
lindig
reviewed
Nov 20, 2024
lindig
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bake in assumptions that have been constant ever since xenstore was created: getdomainpath always returns "/local/domain/domid", /local/domain/domid/vm returns "/vm/uuid", so there's no need to look up that path to get the uuid again
This reduces the number of xenstore accesses from 3 to 1 with no functional change.
As suggested in: #6068 (review)