Remove notion of weird string from sexpr library #6091
Merged
+9
−62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edwintorok
reviewed
Oct 29, 2024
last-genius
approved these changes
Oct 29, 2024
psafont
approved these changes
Oct 29, 2024
|
Going to submit a BVT+BST (just in case) and see about dropping the unused line tracking that Edwin mentioned. |
Removes the remnants of an escaping mechanism once used in xapi. It appears that the format "<<xxx<value<xxx<" was an early escaping format. Also removes the effort at line tracking from the lexer actions. Since the .mli for the generated lexer was only present to have this line variable, it is deleted. Signed-off-by: Colin James <[email protected]>
contificate
force-pushed
the
private/cbarr/no-weirdness
branch
from
685b54d to
36f9993
Compare
edwintorok
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the remnants of an escaping mechanism once used in xapi.
It appears that the format
<<xxx<value<xxx<(wherexxxacted as delimiting tags) was an early escaping format. The construction of these weird strings appears to have been dropped a long time ago (2006).