CP-50789: Enable verified rpc to external host #6082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lindig
approved these changes
Oct 24, 2024
gangj
force-pushed
the
private/gangj/CP-50789
branch
2 times, most recently
from
63e2fa2 to
2da4102
Compare
gangj
changed the title
minglumlu
reviewed
Oct 25, 2024
minglumlu
reviewed
Oct 25, 2024
ocaml/xapi/helpers.ml
Outdated
| let make_external_host_verified_rpc ~__context ext_host_address ext_host_cert | ||
| xml = | ||
| let@ temp_file, temp_out_ch = | ||
| with_temp_file "remote-pool-certificate" ".pem" |
There was a problem hiding this comment.
Would suggest remote-pool-certificate -> external-host-cert for consistency.
minglumlu
reviewed
Oct 25, 2024
minglumlu
approved these changes
Oct 25, 2024
Now xapi supports setting up rpc to hosts in the pool and appliances, while for syncing updates from remote_pool type repository, we need to set up rpc to remote coordinator with its certificate verfieid. Add util Helpers.make_external_host_verified_rpc, which will set up a secure connection to the external host(host outside the pool) with its host certificate verified. Signed-off-by: Gang Ji <[email protected]>
gangj
force-pushed
the
private/gangj/CP-50789
branch
from
2da4102 to
9d677cd
Compare
|
I'd like to see the design for the feature, it's not clear to me why is this new verification type needed. |
psafont
requested changes
Oct 28, 2024
The client needs to get the remote pool coordinator's host certificate, and use the certificate to config the |
robhoes
approved these changes
Oct 29, 2024
psafont
approved these changes
Oct 30, 2024
gangj
merged commit 559821d
into
xapi-project:feature/easier-pool-join
15 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now xapi supports setting up rpc to hosts in the pool and appliances, while for syncing updates from remote_pool type repository, we need to set up rpc to remote coordinator with its certificate verfieid.
Add util Helpers.make_external_host_verified_rpc, which will set up a secure connection to the external host(host outside the pool) with its host certificate verified.