CP-51835: Keep the HTTP /repository handler enabled #6072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gangj
reviewed
Oct 23, 2024
BengangY
force-pushed
the
private/bengangy/CP-51835
branch
from
46d40ff to
4f78fd5
Compare
robhoes
reviewed
Oct 23, 2024
BengangY
force-pushed
the
private/bengangy/CP-51835
branch
from
4f78fd5 to
f54d6b6
Compare
robhoes
approved these changes
Oct 23, 2024
gangj
approved these changes
Oct 23, 2024
|
It would be nice if the mutex name could be changed to something like "pool_update_ops_mutex". |
The HTTP /repository handler is guarded by a mutex `exposing_pool_repo_mutex` currently. Since now HTTP /repository is protected by `session_id` cookie, we can remove the mutex from this handler and keep the handler enabled all the time. Also, rename the mutex `exposing_pool_repo_mutex` to `pool_update_ops_mutex`. Signed-off-by: Bengang Yuan <[email protected]>
BengangY
force-pushed
the
private/bengangy/CP-51835
branch
from
f54d6b6 to
654e7c1
Compare
Updated. |
minglumlu
approved these changes
Oct 24, 2024
minglumlu
merged commit d449aae
into
xapi-project:feature/easier-pool-join
15 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The HTTP /repository handler is guarded by a mutex
exposing_pool_repo_mutexcurrently. Since now HTTP /repository is protected bysession_idcookie, we can remove the mutex and keep the handler enabled all the time. Also, rename the mutexexposing_pool_repo_mutextopool_update_ops_mutex.