Fix some XS9 warnings #6066

rosslagerwall · 2024-10-18T16:31:04Z

Fix a warning reported by newer systemd as well as a build warning I noticed when building with a newer GCC.

GCC correctly reports "pointer targets differ in signedness". Signed-off-by: Ross Lagerwall <[email protected]>

Newer systemd warns that the "syslog" StandardOutput/StandardError type is deprecated and automatically uses the journal instead. Fix this by removing the explicit setting of StandardOutput/StandardError. Instead, the service will use the default values configured in systemd (DefaultStandardOutput/DefaultStandardError) which for a XenServer system will result in the output going to rsyslog. Signed-off-by: Ross Lagerwall <[email protected]>

rosslagerwall · 2024-10-18T16:32:16Z

There doesn't seem to be that much consistency between the settings of StandardOutput / StandardError in the various toolstack service files. I'm not sure whether this is intentional or not.

rosslagerwall · 2024-10-18T16:32:53Z

message-switch.service is also affected by this issue but its service file is not in this repo for some (unknown to me) reason.

psafont · 2024-10-18T16:36:38Z

The service files are in xapi or not, depending on whether they had the service file in the repo or the spec file, back when they were split from xapi. I don't think it's important, and I think they should be hosted in this repository.

freddy77 · 2024-10-19T10:24:05Z

ocaml/libs/xapi-stdext/lib/xapi-stdext-zerocheck/zerocheck_stub.c

@@ -31,7 +31,7 @@ value is_all_zeros(value string, value length)
 	for (i = len / 4; i > 0; i--)
 		if (*p++ != 0)
 			goto notallzero;
-	s = (unsigned char *) p;
+	s = (const char *) p;


Not a regression but looking at the above code even p should be a const pointer. There's also the assumption that sizeof(int) == 4 but I suppose code is not intended to be that portable, although a uint32_t pointer would maybe be better... or replace the 4 with sizeof(int) or sizeof(*p).

Vincent-lau

does this needs to be changed as well?

xen-api/ocaml/forkexecd/lib/fe_systemctl.mli

Lines 35 to 42 in e3f9213

    
           (** [start_transient ?env ?properties ~service cmd args] generates and 
        
               starts a transient systemd [service] that will execute [cmd args]. 
        
               stdout/stderr from the service is redirected to syslog with 
        
               [service] as syslog key.  Additional [properties] can be specified 
        
               that are written into the systemd unit file's [Service] section.  By 
        
               default the service is not auto-restarted when it fails, and there 
        
               is a 10s timeout between SIGTERM and SIGKILL on stop.  On failure it 
        
               raises [Spawn_internal_error(stderr, stdout, Unix.process_status)]

Fix a warning reported by newer systemd as well as a build warning I noticed when building with a newer GCC.

rosslagerwall added 2 commits October 18, 2024 16:22

Fix a build warning with GCC 12.3.0

e83ba5e

GCC correctly reports "pointer targets differ in signedness". Signed-off-by: Ross Lagerwall <[email protected]>

freddy77 reviewed Oct 19, 2024

View reviewed changes

Vincent-lau reviewed Oct 23, 2024

View reviewed changes

lindig approved these changes Oct 24, 2024

View reviewed changes

psafont approved these changes Nov 5, 2024

View reviewed changes

robhoes added this pull request to the merge queue Nov 5, 2024

github-merge-queue bot pushed a commit that referenced this pull request Nov 5, 2024

Fix some XS9 warnings (#6066)

cbbb938

Fix a warning reported by newer systemd as well as a build warning I noticed when building with a newer GCC.

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 5, 2024

psafont added this pull request to the merge queue Nov 6, 2024

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 6, 2024

psafont added this pull request to the merge queue Nov 6, 2024

Merged via the queue into xapi-project:master with commit 3d3bd23 Nov 6, 2024
15 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix some XS9 warnings #6066

Fix some XS9 warnings #6066

rosslagerwall commented Oct 18, 2024

rosslagerwall commented Oct 18, 2024

rosslagerwall commented Oct 18, 2024

psafont commented Oct 18, 2024

freddy77 Oct 19, 2024

Vincent-lau left a comment

	(** [start_transient ?env ?properties ~service cmd args] generates and
	starts a transient systemd [service] that will execute [cmd args].
	stdout/stderr from the service is redirected to syslog with
	[service] as syslog key. Additional [properties] can be specified
	that are written into the systemd unit file's [Service] section. By
	default the service is not auto-restarted when it fails, and there
	is a 10s timeout between SIGTERM and SIGKILL on stop. On failure it
	raises [Spawn_internal_error(stderr, stdout, Unix.process_status)]

Fix some XS9 warnings #6066

Fix some XS9 warnings #6066

Conversation

rosslagerwall commented Oct 18, 2024

rosslagerwall commented Oct 18, 2024

rosslagerwall commented Oct 18, 2024

psafont commented Oct 18, 2024

freddy77 Oct 19, 2024

Choose a reason for hiding this comment

Vincent-lau left a comment

Choose a reason for hiding this comment