[8.2] update-ca-bundle: really avoid failure on missing directory #5919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While no problem was observed while XAPI launches this script, and there is little reason to launch it while the certs dir does not exist (except maybe for testing purposes), there is existing logic to create /etc/stunnel, which when needed will still let `find` fail for lack of /etc/stunnel/certs. Signed-off-by: Yann Dirson <[email protected]>
ydirson
changed the title
bernhardkaindl
approved these changes
Aug 8, 2024
lindig
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While no problem was observed while XAPI launches this script, and there is little reason to launch it while the certs dir does not exist (except maybe for testing purposes), there is existing logic to create /etc/stunnel, which when needed will still let
findfail for lack of /etc/stunnel/certs.