CP-50444: Instrument http svr with dt #5888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edwintorok
reviewed
Jul 29, 2024
lindig
approved these changes
Jul 29, 2024
GabrielBuica
force-pushed
the
private/dbuica/CP-50444
branch
2 times, most recently
from
99fbc72 to
f63ea3d
Compare
psafont
reviewed
Jul 29, 2024
Also known as 'never' ;) |
|
|
psafont
requested changes
Aug 2, 2024
GabrielBuica
force-pushed
the
private/dbuica/CP-50444
branch
from
adbef91 to
7301fae
Compare
psafont
approved these changes
Aug 2, 2024
Adds `with_child_trace` fuction that only creates a span only if there exists a parent. Signed-off-by: Gabriel Buica <[email protected]>
GabrielBuica
force-pushed
the
private/dbuica/CP-50444
branch
from
7301fae to
9c56331
Compare
Intruments the following path of an http request: - `handle_one`, - `callback`, - `callback1`, - `dispatch`, - `jsoncallback`, - `response`. Signed-off-by: Gabriel Buica <[email protected]>
GabrielBuica
force-pushed
the
private/dbuica/CP-50444
branch
from
9c56331 to
b60999b
Compare
|
Passes BVT 202354. |
|
Last commit updates the parent so that the trace looks like this:
|
mg12
reviewed
Aug 7, 2024
mg12
reviewed
Aug 7, 2024
mg12
reviewed
Aug 7, 2024
Intruments the request reading loop. Adds new functionality to the tracing library to update a span with a new parent. This way we can retroactively set the parent span with the correnct one. Signed-off-by: Gabriel Buica <[email protected]>
Fixes warning of unused records fields. These fields are part of the opentelementry spec but we are currently not using them in `xapi`. Signed-off-by: Gabriel Buica <[email protected]>
Increases the default maximum number of spans inside a trace from `1000` to `2500`. Now that we instrumented the internal http calls, with all components enabled, the number of spans inside `xapi` component for a `vm-start` operations is slightly greater than `1000`. This causes spans to be leaked, they are removed from the ongoing span table but never added in the finished tabled. Therefore, they are lost unless the limit is change in `/etc/xapi.conf`. This should fix the issue until we implement a better abstraction for the span hashtables. Signed-off-by: Gabriel Buica <[email protected]>
….Request` Like the title says, this commit adds `Http.Request.with_tracing` to `Http.Request`. This should enable updating the traceparent field of a request while we process it. Signed-off-by: Gabriel Buica <[email protected]>
GabrielBuica
force-pushed
the
private/dbuica/CP-50444
branch
from
28207c0 to
0fd7d6b
Compare
mg12
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instruments functions such as:
handle_onecallbackcallback1dispatchjsoncallbackresponse...
This should help us determine where the time is spent between receiving the request and sending back a response.
Latest BVT passed: 202675 (Dev Run)