-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OIL] Use mustache templates to build Java SDK + Add Java SDK build step to actions #5595
Conversation
5e628b5
to
0bd9973
Compare
2d13f13
to
36d9134
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As above. It wil also need rebasing due to conflicts.
Signed-off-by: Danilo Del Busso <[email protected]>
Signed-off-by: Danilo Del Busso <[email protected]>
3935ae0
to
a6f7dc7
Compare
force push is a rebase on |
d814469
to
6bb8435
Compare
Signed-off-by: Danilo Del Busso <[email protected]>
Signed-off-by: Danilo Del Busso <[email protected]>
Also adds a better definition of the compare function for module Ty. The previous one was leaving duplicates in the set by relying on the underlying `Set.compare`. Signed-off-by: Danilo Del Busso <[email protected]>
6bb8435
to
ed4a861
Compare
Signed-off-by: Danilo Del Busso <[email protected]>
Also update wording in `parseResult` Signed-off-by: Danilo Del Busso <[email protected]>
After the rebase the change regressed Signed-off-by: Danilo Del Busso <[email protected]>
Signed-off-by: Danilo Del Busso <[email protected]>
0b09068
to
9466a7e
Compare
* The value does not belong to this enumeration | ||
*/ | ||
@JsonEnumDefaultValue | ||
UNRECOGNIZED, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is similar to the unknown_enum_value
added in the Go PR. The result is that there are many enums (e.g. LatestSyncedUpdatesAppliedState
or SriovConfigurationMode
etc.) that have both unknown
and unrecognized
and I find this confusing from the client's perspective. I think the best way to handle it is like C# where we add unknown
, but only for the enums that do no already have unknown
.
Unfortunately, I couldn't come up with an easy way to keep the same order of types in
Types.java
. The issue here is that they were added as they were found, so there was no specified order.A good way to check would probably be to compare class structures instead. I'm happy to assist if possible.
The SDK sources are present in the PR's artifacts so you don't have to build them yourself.
This PR also adds the JAR to the release files.
Note that I did keep the existing side-effect operations of updating
enums
,types
, etc.. I found that they weren't that much of an hassle to keep but feel free to weigh in.For result of a release with the changes here see https://github.com/danilo-delbusso/xen-api/releases/tag/v60.1.3