CameraView: only request microphone permission when CaptureMode is se…

…t to Video in UWP (#1963) CameraView: only request microphone permission when CaptureMode is set to Video Co-authored-by: Gerald Versluis <[email protected]>
xamarin · May 1, 2023 · 75886e1 · 75886e1
1 parent f2b8a2b
commit 75886e1
Showing 1 changed file with 8 additions and 3 deletions.
diff --git a/src/CommunityToolkit/Xamarin.CommunityToolkit/Views/CameraView/UWP/CameraViewRenderer.uwp.cs b/src/CommunityToolkit/Xamarin.CommunityToolkit/Views/CameraView/UWP/CameraViewRenderer.uwp.cs
@@ -245,6 +245,7 @@ protected override async void OnElementPropertyChanged(object? sender, PropertyC
 			switch (e.PropertyName)
 			{
 				case nameof(CameraView.CameraOptions):
+				case nameof(CameraView.CaptureMode):
 					await CleanupCameraAsync();
 					await InitializeCameraAsync();
 					break;
@@ -333,8 +334,12 @@ async Task InitializeCameraAsync()
 				return;
 			}
 
-			var audioDevice = await DeviceInformation.FindAllAsync(DeviceClass.AudioCapture);
-			var selectedAudioDevice = audioDevice.Count == 0 ? null : audioDevice[0].Id;
+			string? selectedAudioDevice = null;
+			if (Element.CaptureMode == CameraCaptureMode.Video)
+			{
+				var audioDevice = await DeviceInformation.FindAllAsync(DeviceClass.AudioCapture);
+				selectedAudioDevice = audioDevice.Count == 0 ? null : audioDevice[0].Id;
+			}
 
 			mediaCapture = new MediaCapture();
 			try
@@ -345,7 +350,7 @@ await mediaCapture.InitializeAsync(new MediaCaptureInitializationSettings
 					MediaCategory = MediaCategory.Media,
 					StreamingCaptureMode = selectedAudioDevice == null ? StreamingCaptureMode.Video : StreamingCaptureMode.AudioAndVideo,
 					AudioProcessing = Windows.Media.AudioProcessing.Default,
-					AudioDeviceId = selectedAudioDevice
+					AudioDeviceId = selectedAudioDevice ?? string.Empty,
 				});
 				flash = await Lamp.GetDefaultAsync();