Implement sort-merge join #147
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #147 +/- ##
===========================================
- Coverage 91.41% 75.38% -16.04%
===========================================
Files 20 20
Lines 431 524 +93
===========================================
+ Hits 394 395 +1
- Misses 37 129 +92
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
TODO: revert this commit before merging TImerOutputs helps track the performance of each step of a function, which is useful when narrowing down performance bottlenecks.
adds an ~1-2% performance drop but code is centralized...we're basically done with functionality
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fast sortmerge join, as discussed. It's currently in
TSFrames.fast_join. API is similar toTSFrames.join.The branch is based off my
copycolsbranch, so has some code from there.