-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated variance( ) function #308
Conversation
@ayushpatnaikgit My doctests are failing most of the time but I can't figure out why, here is one of the error messages : ┌ Error: doctest failure in ~/Survey.jl/src/mean.jl:47-55
│
│ ```jldoctest; setup = :(using Survey, StatsBase; apiclus1 = load_data("apiclus1"); dclus1 = SurveyDesign(apiclus1; clusters = :dnum, weights = :pw); bclus1 = dclus1 |> bootweights;)
│
│ julia> mean(:api00, bclus1)
│ 1×2 DataFrame
│ Row │ mean SE
│ │ Float64 Float64
│ ─────┼──────────────────
│ 1 │ 644.169 23.4107
│ ```
│
│ Subexpression:
│
│ mean(:api00, bclus1)
│
│ Evaluated output:
│
│ 1×2 DataFrame
│ Row │ mean SE
│ │ Float64 Float64
│ ─────┼──────────────────
│ 1 │ 644.169 23.4107
│
│ Expected output:
│
│
│
│ diff =
│ 1×2 DataFrame
│ Row │ mean SE
│ │ Float64 Float64
│ ─────┼──────────────────
│ 1 │ 644.169 23.4107
└ @ Documenter.DocTests ~/Survey.jl/src/mean.jl:47 and here is that doctest:
They are failing for all the updated files with the same kind of error message (expected X, evaluated X). |
Codecov Report
@@ Coverage Diff @@
## main #308 +/- ##
===========================================
- Coverage 100.00% 97.66% -2.34%
===========================================
Files 14 14
Lines 242 257 +15
===========================================
+ Hits 242 251 +9
- Misses 0 6 +6
|
README.md
Outdated
@@ -92,7 +92,7 @@ to compute the standard errors. | |||
|
|||
```julia | |||
julia> bootsrs = bootweights(srs; replicates=1000) | |||
ReplicateDesign: | |||
ReplicateDesign{BoootstrapReplicates}: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a triple “o” in BoootstrapReplicates
?
“sometimes doesn't give error message but most of the times does”, is a little weird. It difficult for me to help you on this remotely. Generally speaking, doctests are a bit difficult to get around. |
…to repdesign-variance
Give preference to weights
…to repdesign-variance
PR #304 addresses this. |
bydomain
to use with statistical summary functionsmean
,quantile
,total
, andratio
to use withbydomain
variance
tostderr
Closes #295 and #301