Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Python 3.9 support #720

Merged
merged 5 commits into from
Jan 17, 2025
Merged

Drop Python 3.9 support #720

merged 5 commits into from
Jan 17, 2025

Conversation

tomvothecoder
Copy link
Collaborator

@tomvothecoder tomvothecoder commented Jan 17, 2025

Description

  • Closes [DevOps]: Drop Python 3.9 support  #710

  • Fix ruff issue with zip() using strict=False

    • The strict=False parameter in the zip function is a feature introduced in Python 3.10. When strict=True, the zip function will raise a ValueError if the input iterables are not of the same length. This ensures that all iterables are consumed completely and simultaneously. When strict=False (the default), the zip function will stop creating tuples when the shortest input iterable is exhausted, which is the traditional behavior of zip.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

If applicable:

  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass with my changes (locally and CI/CD build)
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have noted that this is a breaking change for a major release (fix or feature that would cause existing functionality to not work as expected)

- Update `python >=3.10` constraint in conda-env yml files
@tomvothecoder tomvothecoder self-assigned this Jan 17, 2025
@tomvothecoder tomvothecoder added the type: devops Testing, CI/CD, systems configuration label Jan 17, 2025
@github-actions github-actions bot added the type: docs Updates to documentation label Jan 17, 2025
@tomvothecoder tomvothecoder marked this pull request as ready for review January 17, 2025 19:44
Copy link

codecov bot commented Jan 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (27396e5) to head (33c4bee).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #720   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           15        15           
  Lines         1609      1609           
=========================================
  Hits          1609      1609           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tomvothecoder tomvothecoder merged commit d8d91e1 into main Jan 17, 2025
9 checks passed
tomvothecoder added a commit that referenced this pull request Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: devops Testing, CI/CD, systems configuration type: docs Updates to documentation
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[DevOps]: Drop Python 3.9 support
1 participant