[OSU-114] Service sanger admin tab #4931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
27
to
29
| def sanger_ability | ||
| Ability.new(current_user, current_facility) | ||
| end |
There was a problem hiding this comment.
Are we using this method?
There was a problem hiding this comment.
nope, I'll remove it
Comment on lines
1
to
8
| = content_for :h1 do | ||
| = current_facility | ||
| = content_for :sidebar do | ||
| = render "admin/shared/sidenav_product", sidenav_tab: @product.class.name.pluralize.underscore | ||
| = content_for :tabnav do | ||
| = render "admin/shared/tabnav_product", secondary_tab: "sanger" | ||
|
|
||
| %h2= text("title") |
There was a problem hiding this comment.
This part is also in show and I think it's the same. WDYT about extracting it to a partial?
There was a problem hiding this comment.
I created a partial for product manage (the first 6 lines that it's used in several places)
vendor/engines/sanger_sequencing/db/migrate/20250113205804_add_product_group_primer.rb
Show resolved
Hide resolved
LeticiaErrandonea
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes
SangerSequencing::SangerProductmodel which is a rename of the existingSangerSequencing::ProductGroup.Screenshot