Refactor error handling #4856
Open
Refactor error handling #4856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diebas
force-pushed
the
refactor-error-handling
branch
3 times, most recently
from
4b0e849 to
6df5639
Compare
Also run `rails g controller errors not_found internal_server_error`
diebas
force-pushed
the
refactor-error-handling
branch
from
6df5639 to
90d4c13
Compare
Comment on lines
+171
to
+172
| def with_dropped_params(&) | ||
| QuietStrongParams.with_dropped_params(&) |
There was a problem hiding this comment.
Was this change automatically done by the linter?
There was a problem hiding this comment.
Yes, I didn't change this line
| if current_user | ||
| render "errors/forbidden", status: :forbidden | ||
| else | ||
| redirect_to new_user_session_path, alert: "You need to login to access this page." and return |
There was a problem hiding this comment.
Why do we need to return? Is it the same as doing this?
Suggested change
| redirect_to new_user_session_path, alert: "You need to login to access this page." and return | |
| return redirect_to new_user_session_path, alert: "You need to login to access this page." |
spec/controller_spec_helper.rb
Outdated
| if login | ||
| it_should_require_login | ||
| else | ||
| it do |
There was a problem hiding this comment.
Should we add some text here?
spec/controller_spec_helper.rb
Outdated
| if login | ||
| it_should_require_login | ||
| else | ||
| it do |
There was a problem hiding this comment.
Should we add some text here?
| @@ -100,8 +94,7 @@ def do_request | |||
|
|
|||
| it "does not allow the purchaser" do | |||
| sign_in purchaser | |||
| do_request | |||
| expect(response.status).to eq(403) | |||
| expect { do_request }.to raise_error(CanCan::AccessDenied) | |||
There was a problem hiding this comment.
Can we use the shared example here?
| @@ -58,8 +58,7 @@ | |||
| visit facility_user_accounts_path("all", new_user) | |||
| expect(page).not_to have_content("Clone") | |||
|
|
|||
| visit facility_user_clone_account_memberships_path("all", new_user) | |||
| expect(page.status_code).to eq(403) | |||
| expect { visit facility_user_clone_account_memberships_path("all", new_user) }.to raise_error(CanCan::AccessDenied) | |||
There was a problem hiding this comment.
Can we use the shared example here?
| end | ||
|
|
||
| it "does not have a remove link present" do | ||
| expect { visit facility_price_groups_path(facility) }.to raise_error(CanCan::AccessDenied) |
There was a problem hiding this comment.
Can we use the shared example here?
| @@ -80,8 +80,7 @@ | |||
|
|
|||
| it "cannot view the page" do | |||
| expect(reservation.order_detail).not_to be_problem | |||
| visit edit_problem_reservation_path(reservation) | |||
| expect(page.status_code).to eq(404) | |||
| expect { visit edit_problem_reservation_path(reservation) }.to raise_error(ActiveRecord::RecordNotFound) | |||
There was a problem hiding this comment.
Can we use the shared example here?
| @@ -99,8 +98,7 @@ | |||
|
|
|||
| it "cannot view the page" do | |||
| expect(reservation.order_detail).to be_problem | |||
| visit edit_problem_reservation_path(reservation) | |||
| expect(page.status_code).to eq(404) | |||
| expect { visit edit_problem_reservation_path(reservation) }.to raise_error(ActiveRecord::RecordNotFound) | |||
There was a problem hiding this comment.
Can we use the shared example here?
| @@ -117,8 +117,7 @@ | |||
| visit sanger_sequencing_submission_path(SangerSequencing::Submission.last) | |||
| expect(page.status_code).to eq(200) | |||
|
|
|||
| visit edit_sanger_sequencing_submission_path(SangerSequencing::Submission.last) | |||
| expect(page.status_code).to eq(404) | |||
| expect { visit edit_sanger_sequencing_submission_path(SangerSequencing::Submission.last) }.to raise_error(ActiveRecord::RecordNotFound) | |||
There was a problem hiding this comment.
Can we use the shared example here?
|
Some specs are failing 😢 |
diebas
force-pushed
the
refactor-error-handling
branch
from
7e0dc50 to
6be2b80
Compare
joaquinco
reviewed
Jan 13, 2025
Comment on lines
105
to
109
| if current_user | ||
| render "errors/forbidden", status: :forbidden | ||
| else | ||
| return redirect_to new_user_session_path, alert: "You need to login to access this page." | ||
| end |
There was a problem hiding this comment.
is this change necessary? It's not clear to me why if there's a current user an error is renderd and if not a redirection to login is done
config/application.rb
Outdated
| @@ -80,6 +79,10 @@ class Application < Rails::Application | |||
| # Prevent invalid (usually malicious) URLs from causing exceptions/issues | |||
| config.middleware.insert 0, Rack::UTF8Sanitizer | |||
|
|
|||
| config.action_dispatch.rescue_responses["NUCore::PermissionDenied"] = :forbidden | |||
There was a problem hiding this comment.
we should also add CanCan::AccessDenied
joaquinco
approved these changes
Jan 14, 2025
diebas
force-pushed
the
refactor-error-handling
branch
from
dffdb67 to
d0dd51f
Compare
diebas
force-pushed
the
refactor-error-handling
branch
from
515ab8b to
4b96a5c
Compare
diebas
force-pushed
the
refactor-error-handling
branch
from
a395609 to
6d5fcc7
Compare
joaquinco
approved these changes
Jan 17, 2025
spec/system/kiosk_view_spec.rb
Outdated
| @@ -2,7 +2,7 @@ | |||
|
|
|||
| require "rails_helper" | |||
|
|
|||
| RSpec.describe "Launching Kiosk View", :js, feature_setting: { kiosk_view: true, bypass_kiosk_auth: false } do | |||
| RSpec.describe "Launching Kiosk View", :js, :disable_requests_local, :show_rescuable_exceptions, feature_setting: { kiosk_view: true, bypass_kiosk_auth: false } do | |||
There was a problem hiding this comment.
I think the :show_rescuable_exceptions hook is no longer defined
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Notes
Refactor for how errors are being handled in the app.
It consists of adding an error controller with a method for each error type, adding routes to derivate each exception to the respective controller method, and setting up the exception app to use the routes.
Also updated controller tests to check if exceptions are being raised instead of checking that pages are being rendered.