Skip to content

Commit

Permalink
Changes after review
Browse files Browse the repository at this point in the history
  • Loading branch information
joaquinco committed Jan 15, 2025
1 parent e1b5470 commit 44bc0d8
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 4 deletions.
2 changes: 1 addition & 1 deletion app/controllers/services_controller.rb
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ def ensure_sanger_url_service
if sanger_external_service.blank?
Service.transaction do
external_service = UrlService.find_or_create_by(
location: new_sanger_sequencing_submission_path
location: new_sanger_sequencing_submission_url
)
ExternalServicePasser.create!(
external_service:,
Expand Down
4 changes: 2 additions & 2 deletions config/locales/en.controllers.yml
Original file line number Diff line number Diff line change
Expand Up @@ -215,8 +215,8 @@ en:
job_is_queued: "The bulk import is being processed. A report will be sent to %{email} when complete."

services:
sanger_sequencing_enabled: Sanger has been enabled, make sure the Order Form is inactive
sanger_sequencing_disabled: Sanger has been disabled, make sure the Order Form is active
sanger_sequencing_enabled: Sanger has been enabled, make sure the Order Form is inactive.
sanger_sequencing_disabled: Sanger has been disabled, make sure the Order Form is active.

schedule_rules:
create: Schedule Rule was successfully created.
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
# frozen_string_literal: true

class AddProductSangerSequencingEnabled < ActiveRecord::Migration[7.0]
def change
add_column :products, :sanger_sequencing_enabled, :boolean, null: false, default: false
Expand Down
2 changes: 1 addition & 1 deletion spec/system/admin/creating_a_service_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@
include_examples "creates a product with billing mode", "service", "Skip Review"
end

context "when sanger enable si checked" do
context "when sanger enable is checked" do
let(:service) { Service.last }

it "does not show the checkbox if facility is not sanger enabled" do
Expand Down

0 comments on commit 44bc0d8

Please sign in to comment.