Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/responsiveness #1622

Draft
wants to merge 143 commits into
base: main
Choose a base branch
from
Draft

Feat/responsiveness #1622

wants to merge 143 commits into from

Conversation

fussel178
Copy link
Member

@fussel178 fussel178 commented Dec 28, 2022 •
edited
Loading

Summary

Open PR in favor of fork PR for @jantischhoefer 😉

Details

n/a

Additional information

n/a

Related links

  • Fixes # .

CLA

  • I have signed the individual contributor's license agreement and sent it to the board of the WüSpace e. V. organization.

fussel178 added 30 commits April 9, 2022 18:23
@fussel178
chore: Tracking commit
b3e1762
@fussel178
chore: Move to PNPM package manager
64eb904
@fussel178
chore: Move from rollup to parcel as build tool and clean up configur…
b47243e 
…ation files
@fussel178
chore(docs): Update contributing and readme files
e86a2cb
@fussel178
chore(deps): Update pnpm-lock.yaml
a9f0cfb
@fussel178
chore(ci): Fix CI workflows
fb673d9
@fussel178
chore: Add global parcel build and watch scripts
a798e24
@fussel178
chore(ci): Fix check job
31eb671
@fussel178
style(vertx-event-bus): Specify validate function type explicitly
aedc52f
@fussel178
chore(deps): Move to pnpm 7.0.0-rc.3 and Node v16 in CI workflows
4c0ca3c
@fussel178
chore(deps): Clean up development dependencies in workspace root
0e059bd
@fussel178
feat(template): Clean up dependencies and template package.json. Us…
e3d8495 
…e husky as git hook manager
@fussel178
feat(cli): Update package.json and move from CommonJS to ModuleJS. …
f5ecda8 
…Introduce TypeScript build system
@fussel178
feat(cli): Add basic types and library functions
7363dbd
@fussel178
feat(cli): Add git, PNPM, Telestion Project and template actions
a188966
@fussel178
feat(cli): Merge functionality in API export
5170ca1
@fussel178
feat(cli): Add cli binary
7403d5f
@fussel178
feat(cli): Add init command
cd9609e
@fussel178
docs(cli): Add template command
fc4c194
@fussel178
docs: Update contributing guidelines and add excerpt on how to develo…
52825be 
…p and test the Telestion Client changes on a linked test project
@fussel178
chore(deps): Fix PNPM lock file
fc316bb
@fussel178
chore(deps): Fixup dependencies in packages
1e2bd9e
@fussel178
chore: Link build and watch scripts of telestion-client-cli to main…
e318add 
… `package.json`
@fussel178
fix(cli): Fix PNPM link from global function creating relative symbol…
fb838f9 
…ic links on Windows which is not supported
@fussel178
fix: Fix errors introduced by @types/react by pinning all react ver…
b5a1296 
…sions and direct packages to v17
@fussel178
feat(cli): Add function to open URLs to native library
d77268b
@fussel178
feat(cli): Add docs command
b29cbfa
@fussel178
feat(cli): Add getName to package library
fe5b816
@fussel178
feat(cli): Add PSC action
505fa94
@fussel178
feat(cli): Add stats command
f419b5d
fussel178 and others added 26 commits July 17, 2022 18:40
@fussel178
feat(telestion-client-cli): Add setPackageJson functionality to `ps…
500a347 
…c` action
@fussel178
feat(telestion-client-cli): Add pnpmAdd functionality to pnpm action
f5da416
@fussel178
feat(telestion-client-cli): Add install command
4721682
@jantischhoefer
feat(core): add SizeContext
ec4abaf
@jantischhoefer
feat(common): add use-spectrum-size.ts hook
bff1aa5
@jantischhoefer
feat(core): add window size context
d997916
@jantischhoefer
feat(common): make dashboard responsive
ce2f552
@jantischhoefer
feat(common): make connection indicator responsive
adf7f0c
@jantischhoefer
feat(common): decrease margins and gaps on smaller devices
f92b4a2
@jantischhoefer
feat(common): switch dashboard picker to icon button on small devices
b528541
@jantischhoefer
fix(common): icon dimensions
7311e94
@jantischhoefer
feat(common): make login page logo more responsive
20d1c15
@jantischhoefer
feat(common): add window hooks for responsiveness
d23f155
@jantischhoefer
feat(common): export the added window size context
10b6ba4
@jantischhoefer
feat(config-parser): add InnoCube config files
8fa0eb9
@jantischhoefer
feat(common): added responsiveness in header and dashboard, actions t…
df7ad60 
…o fix
@jantischhoefer
feat: increment package(s).json, may be rolled back before merge
f0d0651
@jantischhoefer
feat(common): simplify use-breakpoints
f595dcd
@jantischhoefer
feat(common): make background darker to increase contrast between wid…
3e117f8 
…gets
@jantischhoefer
fix: remove parcel resolver from telestion-client
e037bc9
@jantischhoefer
feat: added documentation
3d3a3ef
@jantischhoefer
update parcel
b737817
@jantischhoefer
cleanup dashboard-picker
be57426
@jantischhoefer
chore: fix versioning
72172f7
@jantischhoefer
refactor: eslint fixes
0d15571
@jantischhoefer
chore: reset package versions
f640ef7
@fussel178 fussel178 requested a review from pklaschka December 28, 2022 17:37
@fussel178 fussel178 marked this pull request as draft December 28, 2022 23:13
pklaschka
pklaschka requested changes Dec 31, 2022
View reviewed changes
Copy link
Member

@pklaschka pklaschka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding my original review back in (original source: #1467):

Great work overall. telestion-client-core should, however, stay clear of UI layer assumptions (such as React Spectrum, or ideally even web browsers as a platform in general).

Therefore, useSize() should move into telestion-client-common and the <SizeContext /> as a part of the <CommonWrapper />.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pklaschka pklaschka pklaschka requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@jantischhoefer jantischhoefer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fussel178 @pklaschka @jantischhoefer