Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move SAMLSSOServiceProviderDO certificate retrieval to SAMLSSOServiceProviderManager layer #6293

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

Osara-B
Copy link
Contributor

@Osara-B Osara-B commented Jan 16, 2025

  • Move SAMLSSOServiceProviderDO certificate retrieval to SAMLSSOServiceProviderManager layer
  • Use addServiceProvider(SAMLSSOServiceProviderDO serviceProviderDO, int tenantId) in place of uploadServiceProvider(SAMLSSOServiceProviderDO serviceProviderDO, int tenantId)
    Related to,

Copy link

codecov bot commented Jan 16, 2025

Codecov Report

Attention: Patch coverage is 20.51282% with 31 lines in your changes missing coverage. Please review.

Project coverage is 45.96%. Comparing base (a08e390) to head (413c5f0).
Report is 70 commits behind head on master.

Files with missing lines Patch % Lines
...n/identity/core/SAMLSSOServiceProviderManager.java 22.85% 20 Missing and 7 partials ⚠️
...ore/dao/RegistrySAMLSSOServiceProviderDAOImpl.java 0.00% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6293      +/-   ##
============================================
+ Coverage     45.89%   45.96%   +0.06%     
- Complexity    14420    14586     +166     
============================================
  Files          1654     1662       +8     
  Lines        103215   104487    +1272     
  Branches      18203    18354     +151     
============================================
+ Hits          47375    48031     +656     
- Misses        49062    49612     +550     
- Partials       6778     6844      +66     
Flag Coverage Δ
unit 29.20% <20.51%> (+0.24%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@darshanasbg darshanasbg merged commit fb8d73c into wso2:master Jan 16, 2025
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants