Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve user defined local auth config #6282

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Thisara-Welmilla
Copy link
Contributor

No description provided.

@Thisara-Welmilla Thisara-Welmilla force-pushed the improve-user-defined-local-auth-config branch 2 times, most recently from 6b46fe4 to 9517ba2 Compare January 14, 2025 05:48
Copy link

codecov bot commented Jan 14, 2025

Codecov Report

Attention: Patch coverage is 70.88608% with 23 lines in your changes missing coverage. Please review.

Project coverage is 45.31%. Comparing base (3061294) to head (b021312).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
...cation/common/ApplicationAuthenticatorService.java 50.00% 8 Missing and 2 partials ⚠️
...lication/mgt/ApplicationManagementServiceImpl.java 40.00% 3 Missing ⚠️
...g/wso2/carbon/idp/mgt/IdentityProviderManager.java 57.14% 3 Missing ⚠️
...ommon/dao/impl/AuthenticatorManagementDAOImpl.java 88.88% 2 Missing ⚠️
...common/dao/impl/AuthenticatorManagementFacade.java 60.00% 2 Missing ⚠️
...n/util/UserDefinedLocalAuthenticatorValidator.java 80.00% 1 Missing and 1 partial ⚠️
.../openjdk/nashorn/JsOpenJdkNashornGraphBuilder.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6282      +/-   ##
============================================
+ Coverage     45.29%   45.31%   +0.01%     
- Complexity    14537    14544       +7     
============================================
  Files          1656     1656              
  Lines        104431   104496      +65     
  Branches      18372    18377       +5     
============================================
+ Hits          47306    47352      +46     
- Misses        50306    50322      +16     
- Partials       6819     6822       +3     
Flag Coverage Δ
unit 29.02% <70.88%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Thisara-Welmilla Thisara-Welmilla force-pushed the improve-user-defined-local-auth-config branch from 9517ba2 to 13c57ad Compare January 14, 2025 08:13
@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12763734142

@Thisara-Welmilla Thisara-Welmilla force-pushed the improve-user-defined-local-auth-config branch from 13c57ad to a86ad5a Compare January 14, 2025 10:48
@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12763734142
Status: failure

@Thisara-Welmilla Thisara-Welmilla force-pushed the improve-user-defined-local-auth-config branch 4 times, most recently from 4f75449 to 0e1d7ca Compare January 14, 2025 12:10
@Thisara-Welmilla Thisara-Welmilla force-pushed the improve-user-defined-local-auth-config branch from 0e1d7ca to b021312 Compare January 14, 2025 13:25
@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12769038570

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12769038570
Status: failure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants