Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor improvement to action execute Method. #6275

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Minor improvement to action execute Method. #6275

wants to merge 1 commit into from

Conversation

Thisara-Welmilla
Copy link
Contributor

Issue:

This will bring the Bring following method which execute the action id list to its interface.

ActionExecutionStatus execute(ActionType actionType, String[] actionIdList,
                              Map<String, Object> eventContext, String tenantDomain)
        throws ActionExecutionException;

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 9, 2025

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12684924743

malithie
malithie reviewed Jan 9, 2025
View reviewed changes
...execution/src/main/java/org/wso2/carbon/identity/action/execution/ActionExecutorService.java
@@ -51,4 +51,17 @@ public interface ActionExecutorService {
ActionExecutionStatus execute(ActionType actionType, Map<String, Object> eventContext, String tenantDomain) throws
ActionExecutionException;

/**
* Resolve the actions by given the action id list and execute them.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not reads right

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12684924743
Status: success

jenkins-is-staging
jenkins-is-staging approved these changes Jan 9, 2025
View reviewed changes
Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/12684924743

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malithie malithie malithie left review comments

@jenkins-is-staging jenkins-is-staging jenkins-is-staging approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Thisara-Welmilla @jenkins-is-staging @malithie