Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused imports #233

Merged
merged 1 commit into from
May 16, 2024
Merged

Remove unused imports #233

merged 1 commit into from
May 16, 2024

Conversation

manukala6
Copy link
Member

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). Don't request your master!
  • Make sure you are making a pull request against the develop branch (left side). Also you should start your branch off our develop.
  • Check the commit's or even all commits' message styles matches our requested structure.
  • Check your code additions will fail neither code linting checks nor unit test.

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

There are over 30 files with unused imports, resulting in a large amount of warning messages during sbt compile.

Issue Number: N/A

What is the new behavior?

  • Removed unused imports
  • Fewer warnings during sbt compile

Does this introduce a breaking change?

  • Yes
  • No

Other information

@manukala6 manukala6 requested review from jterry64 and danscales May 16, 2024 16:44
Copy link
Collaborator

@danscales danscales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for doing this.

@manukala6 manukala6 merged commit b333c28 into master May 16, 2024
3 checks passed
@manukala6 manukala6 deleted the refactor/remove_unused_imports branch May 16, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants