Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake Add documentation to custom defined properties #2131

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

islas
Copy link
Collaborator

@islas islas commented Nov 13, 2024

TYPE: bug fix

KEYWORDS: compilation, cmake

SOURCE: internal

DESCRIPTION OF CHANGES:
Problem:
As noted in #2124, prior to CMake 3.23, when defining custom properties the BRIEF_DOCS and FULL_DOCS are non-optional arguments.

Solution:
Add proper documentation to the custom properties to allow minimum CMake version requirements of the project to remain the same.

ISSUE:
Addresses #2124

TESTS CONDUCTED:

  1. Tested on CMake v3.20.6

RELEASE NOTE:
Add documentation to custom properties in CMake to fix compatibility with older versions.

@weiwangncar
Copy link
Collaborator

The regression test results:

Test Type              | Expected  | Received |  Failed
= = = = = = = = = = = = = = = = = = = = = = = =  = = = =
Number of Tests        : 23           24
Number of Builds       : 60           57
Number of Simulations  : 158           150        0
Number of Comparisons  : 95           86        0

Failed Simulations are: 
None
Which comparisons are not bit-for-bit: 
None

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants