Add additional logic in arch/preamble for finding WRF source directory #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The make logic in arch/preamble for setting the WRF_DIR variable to the location of the compiled WRF source code previously looked either for a directory named ../WRF or a directory named ../WRFV3. In anticipation of users downloading the WRF code as a GitHub archive file, which will unpack to a name like WRF-4.0.1, we need more sophisticated logic for finding this directory. This commit adds checks for the WRF code in ../WRF-4.0.1 and ../WRF-4.0. In future we will likely need a more general solution (e.g., to handle the eventual WRF 4.1 release), but as an immediate fix, checking for the WRF 4.0 or 4.0.1 releases should be sufficient.
|
This PR addresses Issue #72 . |
kkeene44
approved these changes
Oct 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add additional logic in
arch/preamblefor finding the WRF source directoryThe make logic in
arch/preamblefor setting theWRF_DIRvariable to the locationof the compiled WRF source code previously looked either for a directory named
../WRFor a directory named../WRFV3. In anticipation of users downloadingthe WRF code as a GitHub archive file, which will unpack to a name like
WRF-4.0.1, we need more sophisticated logic for finding this directory.This commit adds checks for the WRF code in
../WRF-4.0.1and../WRF-4.0.In future we will likely need a more general solution (e.g., to handle the
eventual WRF 4.1 release), but as an immediate fix, checking for the WRF
4.0 or 4.0.1 releases should be sufficient.