Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nag store admin to check store settings after upgrade #1273

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

JeffPyeBrook
Copy link
Contributor

  • also adds a general administrator nag class to our repertoire to make future nagging and error reporting that much more fun

Addresses issues #1272 and #1270

* also adds a general administrator nag class to our repertoire to make future nagging and error reporting that much more fun

Addresses issues wp-e-commerce#1272 and wp-e-commerce#1270
@JeffPyeBrook
Copy link
Contributor Author

This is what the nags look like if you are interested

image

@danmilward
Copy link

Is this worth a quick blog post? With that image in it so that people can see?

@JeffPyeBrook
Copy link
Contributor Author

Perhaps it would be a good idea, but there are several more bad behaviors that are being addressed in the point release tentatively scheduled for Monday evening. Might be a better idea to have a blog post that covers the whole point release?

@instinct
Copy link
Member

instinct commented May 4, 2014

Agreed :)

On Mon, May 5, 2014 at 8:31 AM, Jeff @ Pye Brook
[email protected]:

Perhaps it would be a good idea, but there are several more bad behaviors
that are being addressed in the point release tentatively scheduled for
Monday evening. Might be a better idea to have a blog post that covers the
whole point release?


Reply to this email directly or view it on GitHubhttps://github.com//pull/1273#issuecomment-42144011
.

Dan Milward

M +64 21 449 901

178 Willis Street – Wellington CBD – Wellington 6011 – New Zealand
www.getshopped.org - www.gamefroot.com

@JustinSainton
Copy link
Member

Let's hold off on adding the new class to 3.8.14.1 and just hook into admin_notices. Happy to consider an admin notifications class as an extension of WPSC_Message_Collection for 3.9.

<?php

/**
* Show WPeC admin notifications, a.k.a. Nags
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we do a class like this, let's extend WPSC_Message_Collection and use that as a data store, using this sub-class for the bits directly related to admin_notices.

Also, let's remove any terminology referring to them as Nags or Notifications - let's call them notices.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants