Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: TypeScript types + production build #45

Merged
merged 3 commits into from
Feb 6, 2024

Conversation

timkurvers
Copy link
Member

@timkurvers timkurvers commented Feb 4, 2024

#44 introduced raw TypeScript support, but did not fix any of the types.

In this PR:

  • Proper TypeScript types used across all files
    • Found 1044 errors in 69 files This is now zero 🥳
  • Partial external vendor type definitions (fengari and @wowserhq/math)
  • Verify production build (in particular the generated filenames)
  • Verify test coverage

@timkurvers timkurvers self-assigned this Feb 4, 2024
Copy link

codecov bot commented Feb 4, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (7355ac0) 0.00% compared to head (24c8edb) 0.00%.

Files Patch % Lines
src/gfx/apis/webgpu/WebGPUDevice.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main     #45     +/-   ##
=======================================
  Coverage   0.00%   0.00%             
=======================================
  Files         83      14     -69     
  Lines       3841     495   -3346     
  Branches     564       0    -564     
=======================================
+ Misses      3838     495   -3343     
+ Partials       3       0      -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@timkurvers timkurvers marked this pull request as ready for review February 5, 2024 23:28
@timkurvers timkurvers changed the title refactor: TypeScript types refactor: TypeScript types + production build Feb 6, 2024
@timkurvers timkurvers merged commit 2228028 into main Feb 6, 2024
4 checks passed
@timkurvers timkurvers deleted the refactor/typescript-types branch February 6, 2024 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant