Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use TypeScript + Node 20 + vite #44

Merged
merged 3 commits into from
Feb 4, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 0 additions & 20 deletions .eslintrc

This file was deleted.

25 changes: 25 additions & 0 deletions .eslintrc.cjs
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
// TODO: Expand @wowserhq/eslint-config with TypeScript variant
module.exports = {
extends: [
'eslint:recommended',
'plugin:@typescript-eslint/recommended',
'plugin:import/recommended',
'plugin:import/typescript',
],
parser: '@typescript-eslint/parser',
plugins: ['@typescript-eslint'],
root: true,
env: { browser: true, node: true },
rules: {
'camelcase': 'off',
'no-console': 'off',
'no-unused-vars': ['error', {
'argsIgnorePattern': '^_',
'varsIgnorePattern': '^_'
}],
'quotes': ['error', 'single', {
'avoidEscape': true
}],
'semi': ['warn'],
},
};
10 changes: 5 additions & 5 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
node-version: [10.x, 12.x, 14.x]
node-version: [18.x, 20.x]
steps:
- uses: actions/checkout@v2
- uses: actions/setup-node@v1
Expand All @@ -22,24 +22,24 @@ jobs:
CI: true

test-coverage:
name: test coverage (12.x)
name: test coverage (20.x)
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/setup-node@v1
with:
node-version: 12
node-version: 20
- run: npm install
- run: npm run test:coverage
- uses: codecov/codecov-action@v1

build:
name: build (12.x)
name: build (20.x)
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/setup-node@v1
with:
node-version: 12
node-version: 20
- run: npm install
- run: npm run build
10 changes: 5 additions & 5 deletions .github/workflows/pull-request.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
node-version: [10.x, 12.x, 14.x]
node-version: [18.x, 20.x]
steps:
- uses: actions/checkout@v2
- uses: actions/setup-node@v1
Expand All @@ -19,24 +19,24 @@ jobs:
CI: true

test-coverage:
name: test coverage (12.x)
name: test coverage (20.x)
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/setup-node@v1
with:
node-version: 12
node-version: 20
- run: npm install
- run: npm run test:coverage
- uses: codecov/codecov-action@v1

build:
name: build (12.x)
name: build (20.x)
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/setup-node@v1
with:
node-version: 12
node-version: 20
- run: npm install
- run: npm run build
9 changes: 4 additions & 5 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -29,16 +29,15 @@ the official client is required.

## Development

Wowser is written in [ES2015+], modularized using [ECMAScript modules] and
developed with [webpack].
Wowser is written in [TypeScript] and developed with [vite].

1. Clone the repository:

```shell
git clone git://github.com/wowserhq/wowser.git
```

2. Download and install [Node.js] 12+ for your platform.
2. Download and install [Node.js] 20+ for your platform.

3. Install dependencies:

Expand Down Expand Up @@ -79,9 +78,9 @@ When contributing, please:

[BLPConverter]: https://github.com/wowserhq/blizzardry#blp
[ECMAScript modules]: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Guide/Modules
[ES2015+]: https://babeljs.io/docs/learn-es2015/
[Node.js]: http://nodejs.org/#download
[StormLib]: https://github.com/wowserhq/blizzardry#mpq
[TypeScript]: https://www.typescriptlang.org/
[Wowser]: https://github.com/wowserhq/wowser
[soon™]: http://www.wowwiki.com/Soon
[webpack]: http://webpack.github.io/
[vite]: https://vitejs.dev/
File renamed without changes.
File renamed without changes.
3 changes: 3 additions & 0 deletions src/index.html → index.html
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
<!DOCTYPE html>
<html>
<head>
<meta charset="utf-8" />
<title>Wowser</title>
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<style>
html, body {
margin: 0;
Expand Down Expand Up @@ -41,5 +43,6 @@
<div class="container">
<canvas></canvas>
</div>
<script type="module" src="/src/index.ts"></script>
</body>
</html>
12 changes: 12 additions & 0 deletions jest.config.cjs
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
module.exports = {
collectCoverageFrom: [
'src/**/*.js',
'src/**/*.ts',
],
coverageDirectory: './coverage/',
moduleFileExtensions: ['js', 'ts'],
testMatch: [
'**/spec/**/*.spec.js',
],
verbose: true,
};
14 changes: 0 additions & 14 deletions jest.config.js

This file was deleted.

3 changes: 3 additions & 0 deletions lint-staged.config.cjs
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
module.exports = {
'*.{js,ts}': ['eslint'],
};
3 changes: 0 additions & 3 deletions lint-staged.config.js

This file was deleted.

Loading
Loading