Skip to content

Commit

Permalink
Support Node 9+ and case-insensitive MPQ chain glob (#109)
Browse files Browse the repository at this point in the history
* Add support for Node 9 & 10
* MPQ chain glob is now case-insensitive
* Update README with instructions for Ubuntu and Debian
  • Loading branch information
avengerweb authored and timkurvers committed Aug 18, 2018
1 parent 334e72f commit c40ce29
Show file tree
Hide file tree
Showing 5 changed files with 36 additions and 11 deletions.
5 changes: 4 additions & 1 deletion .travis.yml
Original file line number Diff line number Diff line change
@@ -1,9 +1,12 @@
sudo: required
language: node_js
node_js:
- '4'
- '5'
- '6'
- '7'
- '8'
- '9'
- '10'
matrix:
fast_finish: true
addons:
Expand Down
22 changes: 22 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,17 @@ to `libblp.dll` and ensure it ends up on the load PATH.
By default, node-gyp compiles ffi for x64 so make sure `libblp.dll`
matches this architecture.

#### Ubuntu, Debian

```shell
sudo apt-get install cmake git gcc
git clone git://github.com/Kanma/BLPConverter.git
cd BLPConverter
cmake CMakeLists.txt -DWITH_LIBRARY=YES
sudo make install
sudo ldconfig
```

#### Other platforms

Compile from source and ensure the library ends up on the load path.
Expand Down Expand Up @@ -190,6 +201,17 @@ rename `StormLib.dll` to `libstorm.dll` and ensure it ends up on the load PATH.
By default, node-gyp compiles ffi for x64 so make sure `libstorm.dll`
matches this architecture.

#### Ubuntu, Debian

```shell
sudo apt-get install cmake git gcc zlib1g-dev
git clone git://github.com/ladislav-zezula/StormLib.git
cd StormLib
cmake CMakeLists.txt -DBUILD_SHARED_LIBS=ON
sudo make install
sudo ldconfig
```

#### Other platforms

Compile from source and ensure the library ends up on the load path.
Expand Down
16 changes: 8 additions & 8 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
"wdt"
],
"dependencies": {
"ffi": "^2.0.0",
"ffi": "node-ffi/node-ffi.git",
"globby": "^8.0.1",
"ref": "^1.3.0",
"ref-array": "^1.1.0",
Expand Down
2 changes: 1 addition & 1 deletion src/lib/mpq/chain.js
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ class MPQChain {
path.join(dataDir, mpq)
));

const archives = glob.sync(patterns);
const archives = glob.sync(patterns, { nocase: true });

const mpq = MPQ.open(archives.shift(), MPQ.OPEN.READ_ONLY);
archives.forEach(archive => {
Expand Down

0 comments on commit c40ce29

Please sign in to comment.