prover: use Keccak256 implementation form Gnark #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bump Gnark to v0.9.2-0.20240322153533-3abde1199375 and gnark-lean-extractor to v3.0.0-20240328211639-501e57e18613. This project was using very old Gnark revision. Bump to the master branch from a few days ago. New Gnark is required for further Keccak development. Gnark-lean-extractor is a dependency that also uses Gnark. Gnark-lean-extractor itself got a Gnark update which resulted in breaking API changes. New API is now v3. Update all uses of this project. Updating gnark-lean-extractor requires update to proven-zk in formal verification Signed-off-by: Wojciech Zmuda <[email protected]>
wzmuda
force-pushed
the
wz/gnark-keccak256
branch
from
976c4ff to
e98887b
Compare
In `keccak` package add a wrapper converting []frontend.Variable to []uints.U8 expected by NewLegacykeccak256. Use the wrapper in insertion and deletion circuits instead of our Keccak256 implementation. Remove the existing Keccak implementation. Add tests of the new implementation. Signed-off-by: Wojciech Zmuda <[email protected]>
wzmuda
force-pushed
the
wz/gnark-keccak256
branch
from
e98887b to
64aeeeb
Compare
|
Updated according to our conversation:
Also Keccak256 API has slightly changed since the draft. Previously it was defined as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
keccakpackage add a wrapper converting []frontend.Variable to[]uints.U8 expected by NewLegacykeccak256. Use the wrapper in insertion
and deletion circuits instead of our Keccak256 implementation.
Remove the existing Keccak implementation. Add tests of the new
implementation.