-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: FM-321 move orb relay client #340
base: main
Are you sure you want to change the base?
Conversation
* Orb Relay support * Fix orb-relay-messages * Remove dead code * Make timeout configurable * Implement a start trigger for stage * Hack to deliver all messages --------- Co-authored-by: Valentyn Valiaiev <[email protected]>
* Custom trigger util * Session ID must be hashed * Support graceful shutdown with retries of pending messages
Skip messages that come from an unexpected src_id
* user feedback messages from pipeline * add Log for distance agent * rename to signup_failure_feedback * add user_distance to DebugReport * add signup_failure_feedback on DebugReport * refactor: dedicated funcs for feedback msgs * fix avg_user_distance NaN bug * add ServerError msg * add Underaged msg * remove info msg * plans now return a vector of msgs * Rework design * send msgs over relay * fix not sending msg on capture failure * fix manual-test * update DEBUG_REPORT_VERSION --------- Co-authored-by: Anastasios Andronidis <[email protected]>
Make Orb-ID announcement more reliable Add reconnect and send_blocking functionality
* update orb-relay-messages * add TooClose feedback * send CaptureTriggerTimeout msg * update DEBUG_REPORT_VERSION
Implement a simple client-side heartbeat
Remove hashing of dst_id
Report CaptureStarted
* Move to new orb-relay architecture * Feedback from @valff
Fix message ordering and protobuf namespace
Decode msgs for type Any to known types
add cargo deny
If a connection dies we need to make sure we continuously retry
* Use tracing with tracing-journald * Remove flexi_logger * Remove `log` * Fallback to stdout if journald is not available or stdout is TTY
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
only the comments marked important:
require changes. The rest, consider optional.
important:
comments block a merge.
suggestion:
are considered a good idea but you can disregard if we don't have time to fix.
nit:
are least important.
resolved in slack to put this into orb-relay-service |
Moving
orb-relay-client
toorb-software
to make it accessible. Specifically to allowfleet-cmdr
to utilize it.Made a patch from
priv-orb-core/orb-relay-client
and applied it toorb-software/relay-client
.(Follow-up PR to
priv-orb-core
to depend onorb-software/relay-client
will come.)