Move all messages under Any and decouple flows #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andronat
requested review from
marioradonic,
paulquinn00,
matthewpaul,
ldulcic,
Michael-Preibisch and
karelispanagiotis
andronat
force-pushed
the
andronat/move-further
branch
2 times, most recently
from
090586c to
f399daf
Compare
paulquinn00
reviewed
Oct 3, 2024
proto/relay.proto
Outdated
| @@ -33,10 +16,6 @@ service AppService { | |||
| rpc AppConnect(stream RequestStream) returns (stream ResponseStream); | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Do we still need OrbService and AppService?
There was a problem hiding this comment.
Probably not. I was just scared to remove them because I'm not sure what's the current status on the server with respect to services. Should I nuke them too?
paulquinn00
approved these changes
Oct 3, 2024
andronat
force-pushed
the
andronat/move-further
branch
2 times, most recently
from
cd1134e to
d0c0b2c
Compare
andronat
force-pushed
the
andronat/move-further
branch
from
d0c0b2c to
b9434ac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.