Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: accept domain_verification intent for portal url generation #57

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

adanselm
Copy link

@adanselm adanselm commented Dec 5, 2023

Also upgrades hackney, fixes 1 warning and 5 tests.

@LauraBeatris
Copy link
Contributor

Hey @adanselm, thanks for the contribution!

hackney is going to be removed on the major release, as we're going to use Tesla by default and allow for folks to use their HTTP client of preference #52

Also, we're removing those provider enum checks as it's the responsibility of the API to return a 400 error in case a client provides an invalid value.

@LauraBeatris LauraBeatris self-requested a review December 5, 2023 18:45
@marktran marktran requested review from hexedpackets and removed request for LauraBeatris August 29, 2024 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants