Library: Port 'Toasts' to Python #732
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UrtsiSantsi
commented
Oct 30, 2023
|
|
||
|
|
||
| action_console.connect("activate", on_activate) | ||
| workbench.window.add_action(action_console) |
There was a problem hiding this comment.
Closed
gregorni
reviewed
Nov 3, 2023
This was referenced Nov 3, 2023
theCapypara
requested changes
Nov 11, 2023
There was a problem hiding this comment.
Hi! Thank you! The demo unfortunately does not launch for me:
Traceback (most recent call last):
File "/app/share/re.sonny.Workbench.Devel/gdbus_ext.py", line 319, in on_method_call
result = method_func(obj, *args)
^^^^^^^^^^^^^^^^^^^^^^^
File "/app/share/re.sonny.Workbench.Devel/python-previewer.py", line 135, in run
spec.loader.exec_module(module)
File "<frozen importlib._bootstrap_external>", line 940, in exec_module
File "<frozen importlib._bootstrap>", line 241, in _call_with_frames_removed
File "/home/marco/.var/app/re.sonny.Workbench.Devel/data/re.sonny.Workbench.Devel/sessions/2023-11-11 17-13-05/main.py", line 52, in <module>
workbench.window.add_action(action_console)
^^^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: 'Window' object has no attribute 'add_action'That part is probably not supportable yet in Python either, see also the Vala code and the issue it's refering: #110
|
That's exactly what I said above 😄.
|
|
I have converted to draft. |
|
Oh, hm! Sorry about that, I think GitHub didn't show me your comments yesterday 🧐 |
|
@UrtsiSantsi could you reopen this against https://github.com/workbenchdev/demos ? I think we should move forward and just disable the action button for now. Like Vala |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.