Address localization and test build failures #23960
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #23951 (comment) I commented regarding a few build failures unrelated to the CocoaPods removal I found when creating #23958
This PR addresses them, see commits list.
I also noticed that the UI tests seem to fail consistently, see for example:
The failing tests are:
I downloaded the test results from Buildkite and had a look. Here's what I found that might help further fixing.
I think
testBasicPostPublishWithCategoryAndTag
andtestTextPostPublish
might be failing because the blogging reminders prompt is not dismissed after creating the post:As for
testAddRemoveFeaturedImage()
, it might be failing because of a change in labels. See in the screenshot of the test result how the test is looking for"CurrentFeaturedImage"
but that only matches for that string are in the test code itself.