Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address localization and test build failures #23960

Merged
merged 2 commits into from
Jan 9, 2025

Conversation

mokagio
Copy link
Contributor

@mokagio mokagio commented Jan 8, 2025

In #23951 (comment) I commented regarding a few build failures unrelated to the CocoaPods removal I found when creating #23958

This PR addresses them, see commits list.


I also noticed that the UI tests seem to fail consistently, see for example:

The failing tests are:

testBasicPostPublishWithCategoryAndTag() in EditorGutenbergTests
testAddRemoveFeaturedImage() in EditorGutenbergTests
testTextPostPublish() in EditorGutenbergTests

I downloaded the test results from Buildkite and had a look. Here's what I found that might help further fixing.

I think testBasicPostPublishWithCategoryAndTag and testTextPostPublish might be failing because the blogging reminders prompt is not dismissed after creating the post:

image

As for testAddRemoveFeaturedImage(), it might be failing because of a change in labels. See in the screenshot of the test result how the test is looking for "CurrentFeaturedImage" but that only matches for that string are in the test code itself.

image

@mokagio mokagio added this to the 25.8 milestone Jan 8, 2025
@mokagio mokagio self-assigned this Jan 8, 2025
@mokagio mokagio requested a review from kean January 8, 2025 10:07
@mokagio mokagio mentioned this pull request Jan 8, 2025
14 tasks
@wpmobilebot
Copy link
Contributor

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr23960-b491858
Version25.6
Bundle IDorg.wordpress.alpha
Commitb491858
App Center BuildWPiOS - One-Offs #11303
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr23960-b491858
Version25.6
Bundle IDcom.jetpack.alpha
Commitb491858
App Center Buildjetpack-installable-builds #10336
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@mokagio mokagio mentioned this pull request Jan 8, 2025
14 tasks
@kean kean merged commit f5ff6d2 into christmas-feature-branch Jan 9, 2025
22 of 27 checks passed
@kean kean deleted the mokagio/christmas-build-failures branch January 9, 2025 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants