-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Site Monitoring: Implement WebKit-based Metrics view #22499
Conversation
28fc812
to
e73bd95
Compare
📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I force quit then reopen the app, I have to login again to see the metrics webview.
Also, feel free to delete WebView.swift, as it's no longer needed. Thanks for implementing WebKitView 🙇♀️
e73bd95
to
08279b9
Compare
Hmm, I couldn't reproduce it. Are there more steps? Are you sure you are not running using the proxy?
Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Turned off the proxy - that was it!
Generated by 🚫 dangerJS |
Reimplement Metrics view using
WebKitViewController
.Out of all the
WKWebView
wrappers in the app, I found theWebKitViewController
works best for our use case. There are alsoWPWebViewController
andBlazeViewController,
but the former missedcustom user agent
, and the latter is Blaze-specific, at least in the name.To test:
Note: I noticed an (existing) performance issue with web views – will investigate it later if time allows.
Known Issues: No dark mode or dynamic type support.
Regression Notes
PR submission checklist:
RELEASE-NOTES.txt
if necessary.UI Changes testing checklist: