refactor: 응답 구분자 상수화

woowacourse · Sep 4, 2023 · fdd145d · fdd145d
1 parent 09a3871
commit fdd145d
Showing 1 changed file with 7 additions and 4 deletions.
diff --git a/tomcat/src/main/java/org/apache/coyote/http11/http/ResponseEntity.java b/tomcat/src/main/java/org/apache/coyote/http11/http/ResponseEntity.java
@@ -11,6 +11,9 @@
 
 public class ResponseEntity {
 
+    public static final String EXTENSION_DELIMITER = ".";
+    public static final String RESPONSE_DELIMITER = " ";
+
     private final HttpVersion httpVersion;
     private final ResponseStatus responseStatus;
     private final List<String> responseHeaders;
@@ -25,12 +28,12 @@ public ResponseEntity(HttpVersion httpVersion, ResponseStatus responseStatus, Li
     }
 
     public static ResponseEntity redirect(String redirectionFile) {
-        List<String> headers = List.of(String.join(" ", "Location:", redirectionFile));
+        List<String> headers = List.of(String.join(RESPONSE_DELIMITER, "Location:", redirectionFile));
         return new ResponseEntity(HttpVersion.HTTP_1_1, ResponseStatus.FOUND, headers, "");
     }
 
     public static ResponseEntity ok(String fileData, String endPoint) {
-        int fileTypeStartIndex = endPoint.indexOf('.');
+        int fileTypeStartIndex = endPoint.indexOf(EXTENSION_DELIMITER);
         String fileExtension = endPoint.substring(fileTypeStartIndex + 1);
 
         List<String> headers = List.of(
@@ -56,7 +59,7 @@ public String generateResponseMessage() {
 
     private String generateStatus() {
         return String.join(
-                " ",
+                RESPONSE_DELIMITER,
                 httpVersion.getVersion(),
                 String.valueOf(responseStatus.getStatusCode()),
                 responseStatus.name(),
@@ -68,7 +71,7 @@ private String generateHeader() {
         StringJoiner headers = new StringJoiner("\r\n");
         for (String header : responseHeaders) {
             headers.add(
-                    String.join(" ", header, "")
+                    String.join(RESPONSE_DELIMITER, header, "")
             );
         }
         if (cookies.containsKey("JSESSIONID")) {