Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: 약속방 중복참여 에러 메세지 수정 #909

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

mzeong
Copy link
Contributor

@mzeong mzeong commented Nov 15, 2024

🚩 연관 이슈

close #908


📝 작업 내용

유저에게 그대로 노출되는 에러 메세지라서 해음의 요청에 따라 자연스러운 메세지로 수정합니다
해당 PR이 머지되면 버전 2.3.2로 배포하겠습니다~


🏞️ 스크린샷 (선택)


🗣️ 리뷰 요구사항 (선택)

Copy link

Test Results

 53 files  ±0   53 suites  ±0   7s ⏱️ -1s
188 tests ±0  188 ✅ ±0  0 💤 ±0  0 ❌ ±0 
189 runs  ±0  189 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 50c9469. ± Comparison against base commit a7ba2fd.

This pull request removes 6 and adds 6 tests. Note that renamed tests count towards both.
com.ody.auth.JwtTokenProviderTest$validateAccessToken ‑ [1] accessToken=com.ody.auth.token.AccessToken@5fd7e75d
com.ody.auth.JwtTokenProviderTest$validateAccessToken ‑ [2] accessToken=com.ody.auth.token.AccessToken@80ea360
com.ody.common.validator.FutureOrPresentDateTimeValidatorTest ‑ [1] date=2024-11-14, time=19:17:29.656179467, expected=false
com.ody.common.validator.FutureOrPresentDateTimeValidatorTest ‑ [2] date=2024-11-14, time=20:17:29.656214011, expected=true
com.ody.common.validator.FutureOrPresentDateTimeValidatorTest ‑ [3] date=2024-11-14, time=18:17:29.656200556, expected=false
com.ody.common.validator.FutureOrPresentDateTimeValidatorTest ‑ [4] date=2024-11-15, time=19:17:29.656179467, expected=true
com.ody.auth.JwtTokenProviderTest$validateAccessToken ‑ [1] accessToken=com.ody.auth.token.AccessToken@78d7f0fd
com.ody.auth.JwtTokenProviderTest$validateAccessToken ‑ [2] accessToken=com.ody.auth.token.AccessToken@fc589f3
com.ody.common.validator.FutureOrPresentDateTimeValidatorTest ‑ [1] date=2024-11-15, time=16:01:59.456546671, expected=false
com.ody.common.validator.FutureOrPresentDateTimeValidatorTest ‑ [2] date=2024-11-15, time=17:01:59.456602615, expected=true
com.ody.common.validator.FutureOrPresentDateTimeValidatorTest ‑ [3] date=2024-11-15, time=15:01:59.456572639, expected=false
com.ody.common.validator.FutureOrPresentDateTimeValidatorTest ‑ [4] date=2024-11-16, time=16:01:59.456546671, expected=true

Copy link

📝 Test Coverage Report

Overall Project 82.12% 🍏
Files changed 100% 🍏

File Coverage
MateService.java 94.79% 🍏

Copy link
Contributor

@eun-byeol eun-byeol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

빠른 제리🐹

@hyeon0208
Copy link
Contributor

"🐀리뷰에 이미 참여했습니다."

Copy link
Contributor

@coli-geonwoo coli-geonwoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 빨라서 좋아요

@coli-geonwoo coli-geonwoo merged commit 4196772 into develop Nov 15, 2024
3 checks passed
@coli-geonwoo coli-geonwoo deleted the feature/908 branch November 15, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refactor: 약속방 중복참여 에러 메세지 수정
4 participants