Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix: 입장, ETA 공지 알림 오지 않는 문제 해결 #605

Merged
merged 2 commits into from
Sep 26, 2024

Conversation

hyeon0208
Copy link
Contributor

@hyeon0208 hyeon0208 commented Sep 26, 2024

🚩 연관 이슈

close #597


📝 작업 내용

  • 입장 알림은 fcmTopic이 null이여서 문제가 발생했었음, 입장 알림 생성시 fcmTopic 추가
  • ETA 공지 알림은 정확히 무슨 이유인지 확인하기 위해 로깅 추가

🏞️ 스크린샷 (선택)


🗣️ 리뷰 요구사항 (선택)

Copy link

Test Results

148 tests  ±0   148 ✅ ±0   5s ⏱️ ±0s
 43 suites ±0     0 💤 ±0 
 43 files   ±0     0 ❌ ±0 

Results for commit 2939336. ± Comparison against base commit ccc71e6.

Copy link

📝 Test Coverage Report

Overall Project 79.6% -0.1%
Files changed 60%

File Coverage
NotificationService.java 98.28% 🍏
MeetingService.java 89.55% 🍏
Notification.java 89.29% 🍏
FcmPushSender.java 4.44% -6.67%

@coli-geonwoo coli-geonwoo merged commit 77af34d into main Sep 26, 2024
3 checks passed
@coli-geonwoo coli-geonwoo deleted the hotfix/597 branch September 26, 2024 07:45
mzeong pushed a commit that referenced this pull request Oct 2, 2024
* fix: 입장 알림 토픽 추가

* fix: ETA NOTICE 로깅 추가
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants