모임 목록 페이지 접근성 개선 #705
Merged
모임 목록 페이지 접근성 개선 #705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cys4585
approved these changes
Oct 23, 2024
| const theme = useTheme(); | ||
|
|
||
| return ( | ||
| <nav css={S.tabStyle}> | ||
| <nav css={S.tabStyle} role="tablist" aria-label="Moim tabs"> |
ss0526100
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR의 목적이 무엇인가요?
모임 목록 페이지의 접근성을 개선하였다.
이슈 ID는 무엇인가요?
설명
2024-10-23.10.1.mp4
수정 전
수정 후
이슈가 더 늘어난 이유는 태그를 버튼으로 변경하면 버튼 내부 색상과 외부 색상의 대비를 주지 않아 발생한 것이니 큰 문제는 아니라고 생각합니다.
질문 혹은 공유 사항 (Optional)