채팅방 정보 가져오기 API 구현 #636
Merged
채팅방 정보 가져오기 API 구현 #636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mingyum-Kim
requested changes
Oct 12, 2024
There was a problem hiding this comment.
Participant를 재활용하지 않고 Loser를 만든 이유가 있나요?
There was a problem hiding this comment.
Loser 에 대한 요구사항이 변경될 수 있다고 생각했는데 지금은 불필요한 것 같네요. Participant로 교체했습니다.
| } | ||
|
|
||
| @Override | ||
| @Transactional |
There was a problem hiding this comment.
Implement 레이어에 트랜잭션을 건 이유가 있나요?
조회만 하고 있는 것 같은데 read only = true설정도 필요할 것 같습니다!
There was a problem hiding this comment.
테스트의 lazyinitializationexception 문제 때문인데요. 서비스 코드에서 이미 트랜잭션을 열어준 상태라 좋지는 않아보입니다. 이것도 이슈로 달아두고 같이 고민해보시죠.
| private final AttributeManagerRegistry attributeManagerRegistry; | ||
| private final ParticipantResolverRegistry participantResolverRegistry; | ||
|
|
||
| @Transactional(readOnly = true) |
ay-eonii
approved these changes
Oct 13, 2024
Comment on lines
11
to
13
| private final String title; | ||
| private final Boolean isLoser; | ||
| private final Long betId; |
| @Override | ||
| public Attributes create(ChatRoom chatRoom, DarakbangMember darakbangMember) { | ||
| Bet bet = betFinder.find(darakbangMember.getDarakbang().getId(), chatRoom.getTargetId()); | ||
| boolean isLoser = bet.isLoser(darakbangMember.getId()); |
There was a problem hiding this comment.
내가 당첨자인지는 추가 기획을 고려하고 넣은신 건가여 ??
There was a problem hiding this comment.
네 맞습니다. 프론트 로직상 필요한 경우가 있을 수 있어서 추가했습니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR의 목적이 무엇인가요?
변경된 요구사항(안내면진다 도메인의 채팅방 오픈 기능) 에 맞추어 채팅방 디테일 정보 가져오기 API 구현
이슈 ID는 무엇인가요?
설명
예시
모임
안내면진다
질문 혹은 공유 사항 (Optional)