다락방 멤버 조회 권한 삭제

backend/src/main/java/mouda/backend/darakbangmember/business/DarakbangMemberService.java

@@ -13,20 +13,17 @@
 import mouda.backend.darakbangmember.presentation.response.DarakbangMemberResponses;
 import mouda.backend.darakbangmember.presentation.response.DarakbangMemberRoleResponse;
 import mouda.backend.member.domain.Member;
-import mouda.backend.member.implement.MemberValidator;
 
 @Service
 @Transactional
 @RequiredArgsConstructor
 public class DarakbangMemberService {
 
-	private final MemberValidator memberValidator;
 	private final DarakbangMemberFinder darakbangMemberFinder;
 	private final DarakbangFinder darakbangFinder;
 
 	@Transactional(readOnly = true)
 	public DarakbangMemberResponses findAllDarakbangMembers(Long darakbangId, DarakbangMember member) {
-		memberValidator.validateNotManager(member);
 		DarakbangMembers darakbangMembers = darakbangMemberFinder.findAllDarakbangMembers(darakbangId);
 
 		return DarakbangMemberResponses.toResponse(darakbangMembers);

backend/src/test/java/mouda/backend/darakbangmember/business/DarakbangMemberServiceTest.java

@@ -5,6 +5,8 @@
 import org.junit.jupiter.api.DisplayName;
 import org.junit.jupiter.api.Nested;
 import org.junit.jupiter.api.Test;
+import org.junit.jupiter.params.ParameterizedTest;
+import org.junit.jupiter.params.provider.EnumSource;
 import org.springframework.beans.factory.annotation.Autowired;
 import org.springframework.boot.test.context.SpringBootTest;
 
@@ -13,9 +15,10 @@
 import mouda.backend.common.fixture.MemberFixture;
 import mouda.backend.darakbang.domain.Darakbang;
 import mouda.backend.darakbang.infrastructure.DarakbangRepository;
+import mouda.backend.darakbangmember.domain.DarakBangMemberRole;
 import mouda.backend.darakbangmember.domain.DarakbangMember;
-import mouda.backend.darakbangmember.exception.DarakbangMemberException;
 import mouda.backend.darakbangmember.infrastructure.DarakbangMemberRepository;
+import mouda.backend.darakbangmember.presentation.response.DarakbangMemberResponses;
 import mouda.backend.darakbangmember.presentation.response.DarakbangMemberRoleResponse;
 import mouda.backend.member.domain.Member;
 import mouda.backend.member.infrastructure.MemberRepository;
@@ -35,23 +38,6 @@ class DarakbangMemberServiceTest {
 	@Autowired
 	private DarakbangMemberService darakbangMemberService;
 
-	@DisplayName("다락방 멤버 조회 테스트")
-	@Nested
-	class DarakbangMemberReadTest {
-
-		@DisplayName("다락방 관리자가 아니라면 멤버 조회에 실패한다.")
-		@Test
-		void failToReadWithoutDarakbangManager() {
-			Member hogee = memberRepository.save(MemberFixture.getHogee());
-			Darakbang darakbang = darakbangRepository.save(DarakbangFixture.getDarakbangWithWooteco());
-			DarakbangMember darakbangHogee = darakbangMemberRepository.save(
-				DarakbangMemberFixture.getDarakbangMemberWithWooteco(darakbang, hogee));
-
-			assertThatThrownBy(() -> darakbangMemberService.findAllDarakbangMembers(darakbang.getId(), darakbangHogee))
-				.isInstanceOf(DarakbangMemberException.class);
-		}
-	}
-
 	@DisplayName("다락방 멤버 권한 조회 테스트")
 	@Nested
 	class DarakbangMemberRoleReadTest {
@@ -70,4 +56,29 @@ void success() {
 			assertThat(response.role()).isEqualTo("OUTSIDER");
 		}
 	}
+
+	@DisplayName("다락방 멤버 조회 테스트")
+	@Nested
+	class DarakbangMemberReadTest {
+
+		@DisplayName("모든 다락방 멤버는 다락방 멤버 목록을 조회할 수 있다.")
+		@EnumSource(mode = EnumSource.Mode.INCLUDE, names = {"MANAGER", "MEMBER"})
+		@ParameterizedTest
+		void failToReadWithoutDarakbangManager(DarakBangMemberRole darakBangMemberRole) {
+			Member hogee = memberRepository.save(MemberFixture.getHogee());
+			Darakbang darakbang = darakbangRepository.save(DarakbangFixture.getDarakbangWithWooteco());
+			DarakbangMember darakbangMember = DarakbangMember.builder()
+				.darakbang(darakbang)
+				.memberId(hogee.getId())
+				.nickname("소소파파")
+				.role(darakBangMemberRole)
+				.build();
+			DarakbangMember darakbangHogee = darakbangMemberRepository.save(darakbangMember);
+
+			DarakbangMemberResponses responses = darakbangMemberService.findAllDarakbangMembers(
+				darakbang.getId(), darakbangHogee);
+
+			assertThat(responses.responses()).hasSize(1);
+		}
+	}
 }