Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

desktop 환경에서의 max width 적용 및 상수화 #118

Merged
merged 1 commit into from
Jul 25, 2024
Merged

desktop 환경에서의 max width 적용 및 상수화 #118

merged 1 commit into from
Jul 25, 2024

Conversation

cys4585
Copy link
Contributor

@cys4585 cys4585 commented Jul 25, 2024 •
edited
Loading

PR의 목적이 무엇인가요?

desktop 환경에서 UI가 양 옆으로 늘어나지 않도록 width의 최대값 적용

이슈 ID는 무엇인가요?

설명

  1. body의 max-width 600px 적용, position이 fixed인 엘리먼트도 body의 max-width와 동일하게 적용
  2. 해당 max-width 상수화 (DISPLAY_MAX_WIDTH)

질문 혹은 공유 사항 (Optional)

image image image

@cys4585 cys4585 self-assigned this Jul 25, 2024
@cys4585 cys4585 added FE 프론트엔드 관련 이슈입니다. 🌱 기능추가 feature (새로운 기능 구현) labels Jul 25, 2024
@cys4585 cys4585 added this to the 2차 스프린트 milestone Jul 25, 2024
@jaeml06
Copy link
Contributor

jaeml06 commented Jul 25, 2024

오카이 확인

ss0526100
ss0526100 approved these changes Jul 25, 2024
View reviewed changes
Copy link
Contributor

@ss0526100 ss0526100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

좋아요~~

@jaeml06 jaeml06 merged commit 29a3f21 into develop-frontend Jul 25, 2024
1 check passed
@jaeml06 jaeml06 deleted the feature/#117 branch July 25, 2024 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaeml06 jaeml06 jaeml06 approved these changes

@ss0526100 ss0526100 ss0526100 approved these changes

Assignees

@cys4585 cys4585

Labels
FE 프론트엔드 관련 이슈입니다. 🌱 기능추가 feature (새로운 기능 구현)
Projects
None yet
Milestone
2차 스프린트
Development

Successfully merging this pull request may close these issues.
3 participants
@cys4585 @jaeml06 @ss0526100